Improve draw performance of editor grids #29476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also there's an option to enable pixel snapping.
|
bdach
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
I think this is okay. I wouldn't enable pixel snapping either because that is some really ugly aliasing on the screenshots provided.
The only caveat is that the draw overhead is basically moved to when the grid parameters are being updated, but that seems like a reasonable tradeoff.
bdach
changed the title
PositionSnapGrid a BufferedContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance difference is most noticeable with circular grid.
Upon closer inspection you may see that grid alignment is slightly different. This is caused by the fact that grid line position may land between pixels and in that case grid isn't perfect as seen here (master)
Unfortunately, same issue occurs with this pr, but in different places, thus causing the visual difference and I'm not sure whether this can be fixed completely.